ребят есть ли какие то правила при ревью чужого кода? типо как комментарии помечать и тд или не критично
Использую свой тул для код ревью, ниже конфигурация чеклиста (убрал поинты, которые относятся чисто к моей компании):
{
"Coverlay": [
"Successful",
"Code Coverage Has Not Dropped",
],
"Correctness": [
"Sufficient Unit Tests",
"Ran Integration Tests (Suggest writing if required)",
],
"Instrumentation": [
"Appropriate Logging",
],
"Design": [
"Makes Sense",
"Logically Correct",
],
"Clarity": [
"Align correctly when multiline",
"README/Documentation has been updated if appropriate",
"No Dumb Comments / Leftover statements / spelling mistakes",
],
"Failure Handling": [
"Null Check for each Loop",
"Edge Cases Covered",
"Clear Exception Strategy",
],
"Security":[
"Only required permissions are provided",
"Excessive access or usage of * avoided",
],
"Git":[
"Commits have been squashed",
“CR link is present",
“Task link is present",
],
"Runbook":[
"Runbook has been updated",
"Dependency API guide has been updated",
],
}
Можно оформить себе в виде памятки на базе этого.