std::vector<std::string>::iterator cmdsplit_it = strsplit(commandstr, ' ', 1).begin(); std::string command = *cmdsplit_it; cmdsplit_it++; line 119: idk if this is something you should do, isn't the vector a temporary that goes out of scope as soon as this line is done?

store the vector itself instead of an iterator lol

yes

std::vector<std::string>::iterator cmdsplit = strsplit(commandstr, ' ', 1); auto cmdsplit_it = cmdsplit.begin(); error: conversion from ‘std::vector<std::__cxx11::basic_string<char> >’ to non-scalar type ‘std::vector<std::__cxx11::basic_string<char> >::iterator’ {aka ‘__gnu_cxx::__normal_iterator<std::__cxx11::basic_string<char>*, std::vector<std::__cxx11::basic_string<char> > >’} requested

std::vector<std::string>::iterator cmdsplit_it = strsplit(commandstr, ' ', 1).begin(); std::string command = *cmdsplit_it; cmdsplit_it++; line 119: idk if this is something you should do, isn't the vector a temporary that goes out of scope as soon as this line is done?

Why is Linux kernel written in C and not in C++? wouldn't OO make things easier?

aaah.

btw if you pass 0 to times, the function splits the string_view unlimited times based on the delimiter and the size of the string_view. either mark it as a feature and document it using a default argument (i changed my code), or throw an exception when times is 0

oh nvm

Fixed and still getting the same error

terminate called after throwing an instance of 'std::logic_error' what(): basic_string::_M_construct null not valid Aborted (core dumped)

wow it works when entering a working command

use a better IDE or more static analysis

Hi guys. I've encountered an issue while writing a simple IRC client/server in C. At some point in the code I've used wgetch to take input from the keyboard. here's the tricky part. Let's say I press the 'f' key. The value returned from wgetch is 'f'. After that I input the pointer to that value inside a method. While debugging, it looks like &value is 'ff' like I pressed the 'f' key twice.. How come? I can send the source code if needed

#include <vector> #include <string> #include <string_view> std::vector<std::string> split(std::string_view s, char delimiter, std::vector<std::string>::size_type times = 0) { std::vector<std::string> to_return; decltype(s.size()) start = 0, finish = 0; while ((finish = s.find_first_of(delimiter, start)) != std::string_view::npos) { to_return.emplace_back(s.substr(start, finish - start)); start = finish + 1; if (to_return.size() == times) { break; } } to_return.emplace_back(s.substr(start)); return to_return; } here's how i would do it

Can you recommend me one? A OSS one?

switch to utf-8. save time, save lives.

the actual error was here

O.o what error?

Well, if the searched for char is not inside the given string it crashes

it should return npos if find_first_of fails :/

How? :)

Hmm it should just return a vector with just one element if it is not found

So... split("hiho", 'ä', 1) Should return a vector with the only element: {"hiho"}

So... split("hiho", 'ä', 1) Should return a vector with the only element: {"hiho"}

this might be a problem with how the comparison function works. try a normal character.

Same happens with 'h'

@leoleoecdsa_bot Do I need to buy a tutorial when learning the C language of mooc

oh. then lemme test

Also affected delemiters won't get removed…

Okay. thx

fixed

#include <vector> #include <string> #include <string_view> std::vector<std::string> split(std::string_view s, char delimiter, std::vector<std::string>::size_type times = 0) { std::vector<std::string> to_return; decltype(s.size()) start = 0, finish = 0; while ((finish = s.find_first_of(delimiter, start)) != std::string_view::npos) { to_return.emplace_back(s.substr(start, finish - start)); start = finish + 1; if (to_return.size() == times) { break; } } to_return.emplace_back(s.substr(start)); return to_return; } here's how i would do it

here?

ye

So... split("hiho", 'ä', 1) Should return a vector with the only element: {"hiho"}

std::vector<std::string> cmdsplit = strsplit(commandstr, ' ', 1); auto cmdsplit_it = cmdsplit.begin(); std::string command = *cmdsplit_it; std::string argsstr; try { cmdsplit_it++; argsstr = *cmdsplit_it; } catch (const std::logic_error& e) { argsstr = ""; } Segmentation fault 🤔

How dafuq is this possible? The pointer to 'd' apparently points to 'dd'

I do not check the size

How can I solve it? 😬

that test was unnecessary. i corrected the code again.

that test was unnecessary. i corrected the code again.

What does it return now if the delimiter was not found?

you don't need to. just ignore it.

I can't ignore it. The value that gets passed inside the method is uncorrect. 'dd' gets passed instead of 'd'

Can anyone help me with this recursive problem ?

Thanks a lot for the helpful link

Hi guys. I've encountered an issue while writing a simple IRC client/server in C. At some point in the code I've used wgetch to take input from the keyboard. here's the tricky part. Let's say I press the 'f' key. The value returned from wgetch is 'f'. After that I input the pointer to that value inside a method. While debugging, it looks like &value is 'ff' like I pressed the 'f' key twice.. How come? I can send the source code if needed