I don't like this code

You are not understanding me.

I'm saying - Is is prone to errors? That's it

It is

It is

for(int i=0;i<a.length()-2;++i){ ans = max(ans,r[i+1] - l[i]-1); }

In the first place you are using really BAD variables names

and yes, lenght method returns std::size_t type, what is not int type, u must be get a warning

So, if i typecast it to int. Would that be good?

My gosh. don't you hear that "Right now, I don't want my code to be of someone else's liking."

When you write your code, follow this quote: Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live.

Yes, but this code is not for development. It is just for me. Do you hear that. Just for me.

That doesn't mean you shouldn't use the best way of doing something

Sir, I'm doing competitive programming and here we are expected to be fast with our solutions.

Just imagine that you are not able to code for weeks Then you come back to the code, when you forget about it, and see this You will waste a ton of time just to trying understand this

Please end this discussion on BAD and GOOD code. I understand what you want to say. But, that's not what I came here to ask.

Good code means less and clearer errors, less and more readable code written

Good code means less and clearer errors, less and more readable code written

If you don't remember what a function or a snippet do during a competition, you're out of luck. If you can't get where your error is because you wrote bad code you lose

Sir, Leave the code readabiltiy to myself. I just have a code of 70-80 lines and Im not dumb to remember the name of variables.

How many competitions did you do?

Mat, when i should use STL loop ? and is it better than raw loop ?

what is an stl loop? std::for_each?

But during debugging, I found that the loop was getting executed twice or thrice

Mat, when i should use STL loop ? and is it better than raw loop ?

+

std::size_t i in "for" loop

I think range-based for is ok, but I think that almost always loops should be separated in functions

a is string mp1 and mp2 are maps here So, should it be : for(std::size_t i=0;i<a.length()-2;++i){ ans = max(ans,mp1[i+1] - mp1[i]-1); } But, Isn't indexing maps with size_t wrong? Idk

a is string mp1 and mp2 are maps here So, should it be : for(std::size_t i=0;i<a.length()-2;++i){ ans = max(ans,mp1[i+1] - mp1[i]-1); } But, Isn't indexing maps with size_t wrong? Idk

indexing maps itself is wrong lol

If we know the key then is that a wrong way to find its value.

indexing maps itself is wrong lol

Read the library... You can't access map's members this way...

I thought there is a [] operator that works on std::map

I thought there is a [] operator that works on std::map

for(int i=0;i<a.length()-2;++i){ ans = max(ans,mp1[i+1] - mp1[i]-1); } i+1 are keys and not iterators.

You can do it if you're using your map as an array of ints. And the variable a where you call length doesn't exists now

Leave the maps, how can i iterate to the length of a -2? for(int i=0;i<a.length()-2;++i){ }

This is the right thing. Probably I would use something else but for your knowledge that's the right way

Well, size_t is unsigned. Right?

Well, size_t is unsigned. Right?

Leave the maps, how can i iterate to the length of a -2? for(int i=0;i<a.length()-2;++i){ }

Then doesn't a.length()-2 becomes unsigned?

That's UB