Mm.. In fact, I guess I can declare something on std if I want, in my libarary, right?

adding declarations or definitions to namespace std or any nested namespace is undefined behavior (*) (*) there are a few exceptions though

like std::hash?

adding declarations or definitions to namespace std or any nested namespace is undefined behavior (*) (*) there are a few exceptions though

No matter what the exceptions are, his library definitely isn't one of them and doesn't belong in std

The formatting is really bad..

functions.cpp: In member function ‘int theGame::gameMechanics()’: functions.cpp:81:2: error: a function-definition is not allowed here before ‘{’ token { ^ functions.cpp:116:6: error: ‘fillInLetters’ was not declared in this scope if(fillInLetters(letter , rapperNames, hideRappersName) == 0 )

your code snipped hasn't even 116 lines... fillInLetters is a function definition inside gameMechanics

Yes

that should explain the error, shouldn't it?

I don't get what you mean 🤔🤔🤔🤔🙄🙄🙄🙄🙃🙃🙃😔😔😔😔😔😔😔😔😔😔😔😔😔😔😔😠😠😠😠😡😡😣😣😣😖😖😖😖😒😒😞😔😔😩😩😩😩😫😟☹️

I don't get what you mean 🤔🤔🤔🤔🙄🙄🙄🙄🙃🙃🙃😔😔😔😔😔😔😔😔😔😔😔😔😔😔😔😠😠😠😠😡😡😣😣😣😖😖😖😖😒😒😞😔😔😩😩😩😩😫😟☹️

https://pastebin.com/FJMN8R9r

int i; `for(i = 0; i <rapperNames.length(); i++) Can be: for(int i = 0; i <rapperNames.length(); i++)` which is both simpler to write, understand and the variable's lifetime ends right after the for loop ends, which is better opposed to keeping it for the entirety of the scope, unless you need it later of course

I'd use i and j, they are used mostly exclusively for the purpose of counter variables

https://pastebin.com/FJMN8R9r

Also an if with just one statement doesn't even need { } So if(condition) { return 0; } Can be just: if(condition) return 0;

Yeah, one of the few places where a single letter variable is perfectly understandable

thats his coding style

I'd agree that if (condition) { } vs if(condition) { } is coding style, but adding 3 lines for a return 0; isn't

Is writing unnecessarily hard to read code coding style?

But it still wouldn't be empty

You have nice patience

So what exactly are you trying to achieve?

Also an if with just one statement doesn't even need { } So if(condition) { return 0; } Can be just: if(condition) return 0;

Don't use only one line. And It's clearer the way he wrote it imo

its a matter of coding style

Two line without { } is also nice

Yeah